Honor canonical viewer plugin attribute 馃馃馃 - #56
Merged
rdasilveiracabral merged 3 commits intoAug 1, 2026
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
The Python tracing hooks already write the canonical
nooa.viewer.pluginspanattribute, but the React trace viewer was still reading only the older
nemo_oo_agents.viewer.pluginkey. That meant a registered viewer plugin couldnot reliably opt into custom spans unless the span name happened to route to
the same renderer.
This PR makes the viewer prefer
nooa.viewer.plugin, keeps the legacy key as acompatibility fallback for imported pre-rename traces, and documents the
canonical metadata contract for future built-in renderers.
This is intentionally a small observability fix. It does not add a new plugin
registry mechanism or a security-specific viewer plugin; it makes the existing
registry seam work with the attribute the current NOOA tracer already emits.
Related issues
None.
Checklist
uv run ruff check .anduv run ruff format --check .pass)uv run pytest)Validation
npm ci --ignore-scripts && npm run builduv sync --all-extras --no-extra sandboxuv run pytest tests/tracing/test_viewer_plugin_attr.py -quv run pytest -q -m "not integration and not stress"uv run ruff check .uv run ruff format --check .src/api/traces.tswithesbuildand verified canonical, legacy, and span-name fallback routing with a Node smoke test.